chore: Change in constraint for list_org_example (#50)

* Change in constraint for list_org_example * Update test * Update variable name * Update variable name Co-authored-by: Stenal P Jolly <[email protected]>
terraform-google-modules · Oct 28, 2021 · a4cea33 · a4cea33
1 parent 904a5c4
commit a4cea33
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/examples/list_org_exclude/README.md b/examples/list_org_exclude/README.md
@@ -9,8 +9,8 @@ Specifically, it sets a trusted image policy so only images from a trusted image
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| image\_project\_id | The ID of a project to trust images from | `string` | n/a | yes |
 | organization\_id | The organization id for putting the policy | `string` | n/a | yes |
+| shared\_reservation\_project\_id | The ID of a project that are allowed to create and own shared reservations in the org | `string` | n/a | yes |
 
 ## Outputs
 

diff --git a/examples/list_org_exclude/main.tf b/examples/list_org_exclude/main.tf
@@ -28,9 +28,9 @@ module "org-policy" {
   source            = "../../"
   policy_for        = "organization"
   organization_id   = var.organization_id
-  constraint        = "compute.trustedImageProjects"
+  constraint        = "compute.sharedReservationsOwnerProjects"
   policy_type       = "list"
-  allow             = ["projects/${var.image_project_id}"]
+  allow             = ["projects/${var.shared_reservation_project_id}"]
   allow_list_length = "1"
-  exclude_projects  = [var.image_project_id]
+  exclude_projects  = [var.shared_reservation_project_id]
 }
diff --git a/examples/list_org_exclude/variables.tf b/examples/list_org_exclude/variables.tf
@@ -19,7 +19,7 @@ variable "organization_id" {
   type        = string
 }
 
-variable "image_project_id" {
-  description = "The ID of a project to trust images from"
+variable "shared_reservation_project_id" {
+  description = "The ID of a project that are allowed to create and own shared reservations in the org"
   type        = string
 }
diff --git a/test/fixtures/list_org_exclude/main.tf b/test/fixtures/list_org_exclude/main.tf
@@ -17,6 +17,6 @@
 module "list-org-exclude" {
   source = "../../../examples/list_org_exclude"
 
-  organization_id  = var.org_id
-  image_project_id = var.project_id
+  organization_id               = var.org_id
+  shared_reservation_project_id = var.project_id
 }
diff --git a/test/integration/list_org_exclude/controls/gcloud.rb b/test/integration/list_org_exclude/controls/gcloud.rb
@@ -27,13 +27,13 @@
 
     let(:data) do
       if subject.exit_status == 0
-        JSON.parse(subject.stdout).select{|x| x['constraint'] == 'constraints/compute.trustedImageProjects'}[0]
+        JSON.parse(subject.stdout).select{|x| x['constraint'] == 'constraints/compute.sharedReservationsOwnerProjects'}[0]
       else
         {}
       end
     end
 
-    describe "list exclude org policy compute.trustedImageProjects"  do
+    describe "list exclude org policy compute.sharedReservationsOwnerProjects"  do
       it "should exist" do
         expect(data).to_not be_empty
       end