-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(push): Add Pub/Sub Subscription support for push payload unwrapping (no wrapper) #141
Closed
+19
−0
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5af8654
Add support for push payload unwrapping (no wrapper)
ORabbit e09ac95
Add support for push payload unwrapping (no wrapper)
ORabbit ce8eb18
Add support for push payload unwrapping (no wrapper)
ORabbit 7ffce7d
Update main.tf
ORabbit fa5b50c
Update README.md
ORabbit cbfcf0f
Update versions.tf
ORabbit 6f48faa
Merge branch 'terraform-google-modules:master' into master
ORabbit 7c88ed5
Update main.tf
ORabbit a5dce96
Merge branch 'master' into master
apeabody fd4bdf3
Merge branch 'terraform-google-modules:master' into master
ORabbit eb85854
Modify no_wrapper definition
ORabbit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,8 @@ module "pubsub" { | |
x-goog-version = "v1beta1" // optional | ||
oidc_service_account_email = "[email protected]" // optional | ||
audience = "example" // optional | ||
no_wrapper = false // optional | ||
no_wrapper_write_metadata = false // optional | ||
expiration_policy = "1209600s" // optional | ||
dead_letter_topic = "projects/my-pubsub-project/topics/example-dl-topic" // optional | ||
max_delivery_attempts = 5 // optional | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, please add any new variables to an example so they are exercised in the Integration CI: https://github.com/terraform-google-modules/terraform-google-pubsub/tree/master/examples