feat(TPG>=4.78)!: add cloud storage subscription support

[lahuang4]

I tried running tests by changing skip: true to skip: false in examples/bigquery/test.yaml, but I'm getting errors along the lines of:

Error: No value for required variable

on variables.tf line 17:
17: variable "project_id" {

The root module input variable "project_id" is not set, and has no default
value. Use a -var or -var-file command line argument to provide a value for
this variable.}

Not sure how to get this to run correctly, would appreciate any tips. But it seems like all the tests are in this state, not just my newly-added cloud_storage test.

[apeabody]

/gcbrun

[apeabody]

Hi @bharathkkb Do you happen to recall why the test referenced above was skipped? https://github.com/terraform-google-modules/terraform-google-pubsub/blob/master/examples/kms/test.yaml#L20

[tcoyze]

Hi @lahuang4, you should be able to pass that error by running (for example):

terraform plan -var "project_id=<your google cloud project id>"

Thank you for contributing! 👍

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[lahuang4]

Oops, I've let this linger too long. Can't seem to figure out how to remove the Stale label; maybe commenting will do the trick to keep the PR alive.

[lahuang4]

OK, I couldn't figure out how to pass the variables to the integration tests in the end (I tried tcoyze@'s suggestion but maybe I am triggering the tests incorrectly because the vars were not persisting to the test run), but I've run the new Cloud Storage example myself by running terraform apply and seeing the correct result!

I've left the newly added test.yaml annotated as skip: true for now.

While running the example I decided that it may be useful to have the bucket name passed in as a variable -- due to the global Cloud Storage bucket namespace it's likely that any placeholder we put in the example is going to be taken already, and the same bucket name is used both in the google_storage_bucket object and the cloud_storage_subscriptions object.

This is ready for review now!

[apeabody]

/gcbrun

[apeabody]

Hi @lahuang4 - From the lint

Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/examples/cloud_storage/README.md /tmp/tmp.pwvq4L4jPc/generate_docs/workspace/examples/cloud_storage/README.md
10d9
< | project\_id | The project ID to manage the Pub/Sub resources | `string` | n/a | yes |
11a11
> | project\_id | The project ID to manage the Pub/Sub resources | `string` | n/a | yes |
17d16
< | project\_id | The project ID |
18a18
> | project\_id | The project ID |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

[apeabody]

Thanks for the contribution @lahuang4! - A few notes below for now :)

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun