Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pubsub iam member for bigquery subscription dead letter topics #146

Conversation

tcoyze
Copy link
Contributor

@tcoyze tcoyze commented Aug 23, 2023

I wanted to add a dead letter topic to my bigquery subscriptions, but noticed the pubsub service account was not granted the appropriate permissions on the dead letter topic (and sub).

Hope this helps other people too!

@tcoyze tcoyze requested a review from a team as a code owner August 23, 2023 22:22
@google-cla
Copy link

google-cla bot commented Aug 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tcoyze tcoyze force-pushed the feat_add_bigquery_subscription_deadletter_iam_member branch from 8d04ccf to 11d312e Compare August 25, 2023 17:47
@tcoyze tcoyze force-pushed the feat_add_bigquery_subscription_deadletter_iam_member branch 2 times, most recently from 114b801 to b784b2a Compare October 25, 2023 17:26
@tcoyze tcoyze force-pushed the feat_add_bigquery_subscription_deadletter_iam_member branch from b784b2a to 2d7f81c Compare November 14, 2023 19:50
@tcoyze tcoyze requested a review from imrannayer as a code owner November 14, 2023 19:50
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit a413f03 into terraform-google-modules:master Nov 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants