Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: resolve Unforeseen Behavior when changing filter - missing bindings on first apply run #173 #174

Merged
merged 3 commits into from
Apr 16, 2024
Merged

fix!: resolve Unforeseen Behavior when changing filter - missing bindings on first apply run #173 #174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a958f8e
fix: resolve Unforeseen Behavior when changing filter - missing bindi…
pawelrosada Jan 12, 2024
1289723
Merge branch 'master' into issue-173
pawelrosada Mar 14, 2024
401e935
Merge branch 'master' into issue-173
imrannayer Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ resource "google_pubsub_subscription_iam_member" "pull_subscription_binding" {
depends_on = [
google_pubsub_subscription.pull_subscriptions,
]

lifecycle {
replace_triggered_by = [google_pubsub_subscription.pull_subscriptions]
}
}

resource "google_pubsub_subscription_iam_member" "push_subscription_binding" {
Expand All @@ -120,6 +124,10 @@ resource "google_pubsub_subscription_iam_member" "push_subscription_binding" {
depends_on = [
google_pubsub_subscription.push_subscriptions,
]

lifecycle {
replace_triggered_by = [google_pubsub_subscription.push_subscriptions]
}
}

resource "google_pubsub_subscription_iam_member" "bigquery_subscription_binding" {
Expand Down Expand Up @@ -454,6 +462,10 @@ resource "google_pubsub_subscription_iam_member" "pull_subscription_sa_binding_s
depends_on = [
google_pubsub_subscription.pull_subscriptions,
]

lifecycle {
replace_triggered_by = [google_pubsub_subscription.pull_subscriptions]
}
}

resource "google_pubsub_subscription_iam_member" "pull_subscription_sa_binding_viewer" {
Expand All @@ -466,4 +478,8 @@ resource "google_pubsub_subscription_iam_member" "pull_subscription_sa_binding_v
depends_on = [
google_pubsub_subscription.pull_subscriptions,
]

lifecycle {
replace_triggered_by = [google_pubsub_subscription.pull_subscriptions]
}
}