feat: make granting service agent bigquery roles optional #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow disabling project-wide BQ binding creation, which can be useful when the module is used multiple times. This avoids destroying bigquery bindings for the whole project when a single module instance is destroyed. Signed-off-by: Antoine Deschênes <[email protected]>
|
@imrannayer lint should pass now, I pushed the doc update |
|
/gcbrun |
imrannayer
approved these changes
Apr 5, 2024
|
Thanks @imrannayer. Are there plans for a new module release soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow disabling project-wide BQ binding creation, which can be useful when the module is used multiple times.
This avoids destroying bigquery bindings for the whole project when a single module instance is destroyed.