-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TPG>=6.2)!: add cloud storage max_messages and use_topic_schema support #204
Conversation
Hello! A friendly nudge on this PR :) |
/gcbrun |
Hi, another nudge on this PR! |
/gcbrun |
Hi @lahuang4 - I pull a fresh/current copy of the repo and it's worked for me:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @lahuang4!
LGTM - @imrannayer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding support to terraform-google-pubsub following adding support in the provider: hashicorp/terraform-provider-google#19338
Similar to #192, I'm having trouble getting the example in
examples/cloud_storage
pick up the new fields. Runningterraform plan
still ignores the specified filename_datetime_format field which was added in the previous PR:Would appreciate any tips for debugging this, but otherwise the change seems complete, so I'm sending it for review. Thanks!