feat: Issue #208: Add no_wrapper settings in push_config #218
Conversation
|
Hi @imrannayer , @apeabody did anyone of you already had the opportunity to look at this PR? Getting the |
|
/gcbrun |
Thanks for the contribution @geryonghost! I've updated against main, and triggered the CI tests. Either @imrannayer or a member of @api-pubsub-and-pubsublite should provide the final review. Cheers! |
|
/gcbrun |
|
/gcbrun |
There was a problem hiding this comment.
Thanks for the contribution @geryonghost! A few quick notes:
| @@ -212,6 +212,13 @@ resource "google_pubsub_subscription" "push_subscriptions" { | |||
| x-goog-version = each.value.minimum_backoff != null ? "x-goog-version" : "v1" | |||
| } | |||
|
|
|||
| dynamic "no_wrapper" { | |||
| for_each = (lookup(each.value, "no_wrapper", true) ? [true] : []) | |||
There was a problem hiding this comment.
I'd suggest the dynamic block be trigger on the presence of the value, and so default the lookup to null given this variable is optional.
| for_each = (lookup(each.value, "no_wrapper", true) ? [true] : []) | |
| for_each = (lookup(each.value, "no_wrapper", null) != null ? [true] : []) |
| dynamic "no_wrapper" { | ||
| for_each = (lookup(each.value, "no_wrapper", true) ? [true] : []) | ||
| content { | ||
| write_metadata = lookup(each.value, "write_metadata", true) |
There was a problem hiding this comment.
Should never fall back to default, but still might want to set to null?
| write_metadata = lookup(each.value, "write_metadata", true) | |
| write_metadata = lookup(each.value, "write_metadata", null) |
The
push_configforresource "google_pubsub_subscription" "push_subscriptions"doesn't include theno_wrappersettings. This has been added.