Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate pull_subscriptions and push_subscriptions to object lists #224

Merged
merged 17 commits into from
Feb 27, 2025
Merged

fix: migrate pull_subscriptions and push_subscriptions to object lists #224

merged 17 commits into from
Feb 27, 2025

Conversation

ktinubu
Copy link
Contributor

@ktinubu ktinubu commented Feb 20, 2025 •
edited
Loading

Migrate pull_subscriptions and push_subscriptions variables to object lists

  • Also adds push endpoint connection metadata from cloud run service uri

@ktinubu ktinubu requested review from imrannayer and a team as code owners February 20, 2025 13:56
@ktinubu ktinubu requested a review from q2w February 20, 2025 13:56
q2w
q2w approved these changes Feb 24, 2025
View reviewed changes
@ktinubu ktinubu requested review from lahuang4 and apeabody February 25, 2025 18:38
@ktinubu
Copy link
Contributor Author

ktinubu commented Feb 27, 2025

Integration test diff looks good.

uniform_bucket_level_access diff is expected because it was updated it in PR#219

apeabody
apeabody approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved by q2w

@apeabody apeabody merged commit f239247 into terraform-google-modules:main Feb 27, 2025
4 checks passed
@release-please release-please bot mentioned this pull request Feb 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@q2w q2w q2w approved these changes

@apeabody apeabody apeabody approved these changes

@imrannayer imrannayer Awaiting requested review from imrannayer imrannayer is a code owner

@lahuang4 lahuang4 Awaiting requested review from lahuang4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktinubu @q2w @apeabody