Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update version in readme #111

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

OhMyMndy
Copy link
Contributor

@OhMyMndy OhMyMndy commented Feb 7, 2024

Hi!

Small PR to update the README to use version 4 instead of 3, I have been breaking my head over certain bugs for the past hour, finding out later that I used an older version of the module...

@OhMyMndy OhMyMndy requested a review from a team as a code owner February 7, 2024 09:33
Copy link

google-cla bot commented Feb 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OhMyMndy OhMyMndy changed the title Update version in readme fix: update version in readme Feb 7, 2024
Copy link

github-actions bot commented Apr 7, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Apr 7, 2024
@apeabody apeabody removed the Stale label Apr 8, 2024
@apeabody apeabody changed the title fix: update version in readme docs: update version in readme Apr 8, 2024
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @OhMyMndy!

@apeabody apeabody enabled auto-merge (squash) April 8, 2024 15:45
@apeabody apeabody merged commit 8b6b934 into terraform-google-modules:master Apr 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants