Skip to content

Commit

Permalink
Merge branch 'master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
tjy9206 authored Oct 21, 2024
2 parents f98d795 + 003237e commit 0227668
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions docs/upgrading_to_sql_db_23.0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Upgrading to SQL DB 23.0

The 23.0 release of SQL DB is a backward incompatible release.

# Cloud SQL Service Account role update

Changed `storage.objectCreator` role to `storage.objectAdmin` for Cloud SQL Service Account on the bucket used for exporting the database, due to GCP internal changes in the export process.
2 changes: 1 addition & 1 deletion modules/backup/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ resource "google_storage_bucket_iam_member" "sql_instance_account" {
count = var.enable_export_backup ? 1 : 0
bucket = split("/", var.export_uri)[2] #Get the name of the bucket out of the URI
member = "serviceAccount:${data.google_sql_database_instance.backup_instance.service_account_email_address}"
role = "roles/storage.objectCreator"
role = "roles/storage.objectAdmin"
}

# We want to get notified if there hasn't been at least one successful backup in a day
Expand Down

0 comments on commit 0227668

Please sign in to comment.