fix: Don't require var.zone for read_replica instances
#513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, a value is required for either `var.read_replicas[replica]["zone"]` or `var.zone` as a fallback.
This commit tweaks that behaviour to use _either_ `var.zone` or a random
available zone as the fallback.
Backwards compatibility should be retained, as `local.zone` already
prefers the value of `var.zone` over a random available zone.
Also worth noting that `local.zone` is already used in the
`location_preference {}` block.
The `lookup()` func was causing errors such as `Invalid value for "str" parameter: argument must not be null.` on the `region` and `encryption_key_name` fields. I believe this is related to hashicorp/terraform#32157. By switching to `coalesce()`, the first non-null value will be returned, which I believe is the intended behaviour with the previous `lookup()` usage.
This mirrors the API behaviour, and fixes an issue with the `coalesce()` function not finding a value for `edition`.
|
/gcbrun |
added 2 commits
October 2, 2023 11:44
This avoids a constant flapping reported by Terraform if the variable default is `ENTERPRISE`.
With a count that depends on `var.zone`, I was getting the following error: ``` The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created. ``` Update references to use resource without the count index.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
/gcbrun |
|
@fatmcgav - sorry for the delay on this. Can you please sign the CLA? |
|
@g-awmalik no worries... So I've changed jobs since opening this PR, but will see if can sort the cla out tomorrow 👍 |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a value is required for either
var.read_replicas[replica]["zone"]orvar.zoneas a fallback.This commit tweaks that behaviour to use either
var.zoneor a randomavailable zone as the fallback.
Backwards compatibility should be retained, as
local.zonealreadyprefers the value of
var.zoneover a random available zone.Also worth noting that
local.zoneis already used in thelocation_preference {}block.