feat: adding data_cache_config to postgresql module

[nityanavali1]

No description provided.

[isaurabhuttam]

/gcbrun

[nityanavali1]

PR is ready to be merged. Need Approval

[imrannayer]

Waiting for PR #523 to merge.

[imrannayer]

/gcbrun

[imrannayer]

@nityanavali1 according to documentation this feature is only available for mysql.

data_cache_enabled - (Optional) Whether data cache is enabled for the instance. Defaults to false Can only be used with MYSQL.

[nityanavali1]

@nityanavali1 according to documentation this feature is only available for mysql.

data_cache_enabled - (Optional) Whether data cache is enabled for the instance. Defaults to false Can only be used with MYSQL.

• Documentation update is released and will take some time to reflect the changes. PR for updating terraform doc is merged Update documentation and add test case for data cache setting as it is available for postgres now GoogleCloudPlatform/magic-modules#9241 and the feature is GA available for postgres now.

[nityanavali1]

@nityanavali1 according to documentation this feature is only available for mysql.
data_cache_enabled - (Optional) Whether data cache is enabled for the instance. Defaults to false Can only be used with MYSQL.

• Documentation update is released and will take some time to reflect the changes. PR for updating terraform doc is merged Update documentation and add test case for data cache setting as it is available for postgres now GoogleCloudPlatform/magic-modules#9241 and the feature is GA available for postgres now.

@imrannayer Can you approve this change based on above comments?

[imrannayer]

@nityanavali1 can you plz enable this feature in this example so we can test this feature?
Also do you know why postgres page is disabled in official doc

[nityanavali1]

@nityanavali1 can you plz enable this feature in this example so we can test this feature? Also do you know why postgres page is disabled in official doc

The official docs will be updated on Nov 8. Although the rollout is 100% complete for this feature. As of today customers can go ahead and create postgres instances with data cache enabled https://screenshot.googleplex.com/8fvJsiEDJmQ3TWm. If the recommendation is to wait until docs update. Will do so.

For

• can you plz enable this feature in this example so we can test this feature?
  Not sure how this can be achieved as postgres module (modules/postgresql/variables.tf) does not expose the variable for data cache without this PR being submitted.

[imrannayer]

@nityanavali1 thanks for confirming the feature. You pass the value in example as part of your PR. It will work fine during the test for your PR.

[imrannayer]

/gcbrun

[imrannayer]

/gcbrun

[nityanavali1]

/gcbrun

[imrannayer]

/gcbrun

[imrannayer]

/gcbrun

[imrannayer]

/gcbrun