-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add alternate defaults for mysql & postgresql blueprint #646
chore: Add alternate defaults for mysql & postgresql blueprint #646
Conversation
@qz267 is there any reason for changing defaults instead of sending values and override it in module call? |
Sorry for the confusion, I was trying to surface some of my WIP changes, to ask for early feedbacks, PR title updated. b/362377949 is the original request, I don't have strong preference about update in variables or override them in the module call, any suggestions are welcomed, thanks! |
@qz267 I think it will be better to take alternate route instead of changing defaults in the module as this change will require all the existing user of the module to adjust code for new defaults. @bharathkkb can u plz review? |
I got @q2w suggested using |
@qz267 We should also update for modules/postgresql. |
/gcbrun |
More details in http://docs/document/d/1LMsDRy0zMKQrPUDJ4chlPtqul9bwXs90QH6N8xqZ78I?tab=t.0#heading=h.qx5xjbm73vyx