Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update connection metadata #655

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Oct 10, 2024

Update connection source version to comply with semantic versioning

@q2w q2w marked this pull request as ready for review October 10, 2024 08:56
@q2w q2w requested review from isaurabhuttam, imrannayer and a team as code owners October 10, 2024 08:56
@@ -223,7 +223,7 @@ spec:
connections:
- source:
source: github.com/terraform-google-modules/terraform-google-network//modules/vpc
version: v9.1.0
version: ">= 9.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@q2w Let'ts keep an upper bound on the major version as that may contain breaking changes ~> 9.1

@q2w q2w enabled auto-merge (squash) October 14, 2024 20:34
@q2w q2w merged commit 600e0a9 into terraform-google-modules:master Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants