fix(variables)!: allow optional attributes for update_policy object (#…

…407)

Co-authored-by: Andrew Peabody <[email protected]>

autogen/variables.tf.tmpl

@@ -118,16 +118,16 @@ variable "stateful_ips" {
 variable "update_policy" {
   description = "The rolling update policy. https://www.terraform.io/docs/providers/google/r/compute_region_instance_group_manager#rolling_update_policy"
   type = list(object({
-    max_surge_fixed                = number
-    instance_redistribution_type   = string
-    max_surge_percent              = number
-    max_unavailable_fixed          = number
-    max_unavailable_percent        = number
-    min_ready_sec                  = number
-    replacement_method             = string
+    max_surge_fixed                = optional(number)
+    instance_redistribution_type   = optional(string)
+    max_surge_percent              = optional(number)
+    max_unavailable_fixed          = optional(number)
+    max_unavailable_percent        = optional(number)
+    min_ready_sec                  = optional(number)
+    replacement_method             = optional(string)
     minimal_action                 = string
     type                           = string
-    most_disruptive_allowed_action = string
+    most_disruptive_allowed_action = optional(string)
   }))
   default = []
 }

autogen/versions.tf.tmpl

@@ -15,7 +15,7 @@
  */
 
 terraform {
-  required_version = ">=0.13.0"
+  required_version = ">=1.3.0"
   required_providers {
     google = {
       source  = "hashicorp/google"

examples/mig/full/variables.tf

@@ -169,16 +169,16 @@ variable "distribution_policy_zones" {
 variable "update_policy" {
   description = "The rolling update policy. https://www.terraform.io/docs/providers/google/r/compute_region_instance_group_manager#rolling_update_policy"
   type = list(object({
-    max_surge_fixed                = number
-    instance_redistribution_type   = string
-    max_surge_percent              = number
-    max_unavailable_fixed          = number
-    max_unavailable_percent        = number
-    min_ready_sec                  = number
-    replacement_method             = string
+    max_surge_fixed                = optional(number)
+    instance_redistribution_type   = optional(string)
+    max_surge_percent              = optional(number)
+    max_unavailable_fixed          = optional(number)
+    max_unavailable_percent        = optional(number)
+    min_ready_sec                  = optional(number)
+    replacement_method             = optional(string)
     minimal_action                 = string
     type                           = string
-    most_disruptive_allowed_action = string
+    most_disruptive_allowed_action = optional(string)
   }))
   default = []
 }

modules/mig/README.md

@@ -45,7 +45,7 @@ The current version is 2.X. The following guides are available to assist with up
 | stateful\_ips | Statful IPs created on the instances that will be preserved on instance delete. https://cloud.google.com/compute/docs/instance-groups/configuring-stateful-ip-addresses-in-migs | <pre>list(object({<br>    interface_name = string<br>    delete_rule    = string<br>    is_external    = bool<br>  }))</pre> | `[]` | no |
 | target\_pools | The target load balancing pools to assign this group to. | `list(string)` | `[]` | no |
 | target\_size | The target number of running instances for this managed instance group. This value should always be explicitly set unless this resource is attached to an autoscaler, in which case it should never be set. | `number` | `1` | no |
-| update\_policy | The rolling update policy. https://www.terraform.io/docs/providers/google/r/compute_region_instance_group_manager#rolling_update_policy | <pre>list(object({<br>    max_surge_fixed                = number<br>    instance_redistribution_type   = string<br>    max_surge_percent              = number<br>    max_unavailable_fixed          = number<br>    max_unavailable_percent        = number<br>    min_ready_sec                  = number<br>    replacement_method             = string<br>    minimal_action                 = string<br>    type                           = string<br>    most_disruptive_allowed_action = string<br>  }))</pre> | `[]` | no |
+| update\_policy | The rolling update policy. https://www.terraform.io/docs/providers/google/r/compute_region_instance_group_manager#rolling_update_policy | <pre>list(object({<br>    max_surge_fixed                = optional(number)<br>    instance_redistribution_type   = optional(string)<br>    max_surge_percent              = optional(number)<br>    max_unavailable_fixed          = optional(number)<br>    max_unavailable_percent        = optional(number)<br>    min_ready_sec                  = optional(number)<br>    replacement_method             = optional(string)<br>    minimal_action                 = string<br>    type                           = string<br>    most_disruptive_allowed_action = optional(string)<br>  }))</pre> | `[]` | no |
 | wait\_for\_instances | Whether to wait for all instances to be created/updated before returning. Note that if this is set to true and the operation does not succeed, Terraform will continue trying until it times out. | `string` | `"false"` | no |
 
 ## Outputs

modules/mig/metadata.yaml

@@ -28,7 +28,7 @@ spec:
     version: 11.1.0
     actuationTool:
       flavor: Terraform
-      version: ">=0.13.0"
+      version: ">=1.3.0"
     description: {}
   content:
     examples:
@@ -257,16 +257,16 @@ spec:
         description: The rolling update policy. https://www.terraform.io/docs/providers/google/r/compute_region_instance_group_manager#rolling_update_policy
         varType: |-
           list(object({
-              max_surge_fixed                = number
-              instance_redistribution_type   = string
-              max_surge_percent              = number
-              max_unavailable_fixed          = number
-              max_unavailable_percent        = number
-              min_ready_sec                  = number
-              replacement_method             = string
+              max_surge_fixed                = optional(number)
+              instance_redistribution_type   = optional(string)
+              max_surge_percent              = optional(number)
+              max_unavailable_fixed          = optional(number)
+              max_unavailable_percent        = optional(number)
+              min_ready_sec                  = optional(number)
+              replacement_method             = optional(string)
               minimal_action                 = string
               type                           = string
-              most_disruptive_allowed_action = string
+              most_disruptive_allowed_action = optional(string)
             }))
         defaultValue: []
       - name: wait_for_instances

modules/mig/variables.tf

@@ -100,16 +100,16 @@ variable "stateful_ips" {
 variable "update_policy" {
   description = "The rolling update policy. https://www.terraform.io/docs/providers/google/r/compute_region_instance_group_manager#rolling_update_policy"
   type = list(object({
-    max_surge_fixed                = number
-    instance_redistribution_type   = string
-    max_surge_percent              = number
-    max_unavailable_fixed          = number
-    max_unavailable_percent        = number
-    min_ready_sec                  = number
-    replacement_method             = string
+    max_surge_fixed                = optional(number)
+    instance_redistribution_type   = optional(string)
+    max_surge_percent              = optional(number)
+    max_unavailable_fixed          = optional(number)
+    max_unavailable_percent        = optional(number)
+    min_ready_sec                  = optional(number)
+    replacement_method             = optional(string)
     minimal_action                 = string
     type                           = string
-    most_disruptive_allowed_action = string
+    most_disruptive_allowed_action = optional(string)
   }))
   default = []
 }

modules/mig/versions.tf

@@ -15,7 +15,7 @@
  */
 
 terraform {
-  required_version = ">=0.13.0"
+  required_version = ">=1.3.0"
   required_providers {
     google = {
       source  = "hashicorp/google"

modules/mig_with_percent/README.md

@@ -46,7 +46,7 @@ The current version is 2.X. The following guides are available to assist with up
 | stateful\_ips | Statful IPs created on the instances that will be preserved on instance delete. https://cloud.google.com/compute/docs/instance-groups/configuring-stateful-ip-addresses-in-migs | <pre>list(object({<br>    interface_name = string<br>    delete_rule    = string<br>    is_external    = bool<br>  }))</pre> | `[]` | no |
 | target\_pools | The target load balancing pools to assign this group to. | `list(string)` | `[]` | no |
 | target\_size | The target number of running instances for this managed instance group. This value should always be explicitly set unless this resource is attached to an autoscaler, in which case it should never be set. | `number` | `1` | no |
-| update\_policy | The rolling update policy. https://www.terraform.io/docs/providers/google/r/compute_region_instance_group_manager#rolling_update_policy | <pre>list(object({<br>    max_surge_fixed                = number<br>    instance_redistribution_type   = string<br>    max_surge_percent              = number<br>    max_unavailable_fixed          = number<br>    max_unavailable_percent        = number<br>    min_ready_sec                  = number<br>    replacement_method             = string<br>    minimal_action                 = string<br>    type                           = string<br>    most_disruptive_allowed_action = string<br>  }))</pre> | `[]` | no |
+| update\_policy | The rolling update policy. https://www.terraform.io/docs/providers/google/r/compute_region_instance_group_manager#rolling_update_policy | <pre>list(object({<br>    max_surge_fixed                = optional(number)<br>    instance_redistribution_type   = optional(string)<br>    max_surge_percent              = optional(number)<br>    max_unavailable_fixed          = optional(number)<br>    max_unavailable_percent        = optional(number)<br>    min_ready_sec                  = optional(number)<br>    replacement_method             = optional(string)<br>    minimal_action                 = string<br>    type                           = string<br>    most_disruptive_allowed_action = optional(string)<br>  }))</pre> | `[]` | no |
 | wait\_for\_instances | Whether to wait for all instances to be created/updated before returning. Note that if this is set to true and the operation does not succeed, Terraform will continue trying until it times out. | `string` | `"false"` | no |
 
 ## Outputs

modules/mig_with_percent/metadata.yaml

@@ -28,7 +28,7 @@ spec:
     version: 11.1.0
     actuationTool:
       flavor: Terraform
-      version: ">=0.13.0"
+      version: ">=1.3.0"
     description: {}
   content:
     examples:
@@ -265,16 +265,16 @@ spec:
         description: The rolling update policy. https://www.terraform.io/docs/providers/google/r/compute_region_instance_group_manager#rolling_update_policy
         varType: |-
           list(object({
-              max_surge_fixed                = number
-              instance_redistribution_type   = string
-              max_surge_percent              = number
-              max_unavailable_fixed          = number
-              max_unavailable_percent        = number
-              min_ready_sec                  = number
-              replacement_method             = string
+              max_surge_fixed                = optional(number)
+              instance_redistribution_type   = optional(string)
+              max_surge_percent              = optional(number)
+              max_unavailable_fixed          = optional(number)
+              max_unavailable_percent        = optional(number)
+              min_ready_sec                  = optional(number)
+              replacement_method             = optional(string)
               minimal_action                 = string
               type                           = string
-              most_disruptive_allowed_action = string
+              most_disruptive_allowed_action = optional(string)
             }))
         defaultValue: []
       - name: wait_for_instances

modules/mig_with_percent/variables.tf

@@ -110,16 +110,16 @@ variable "stateful_ips" {
 variable "update_policy" {
   description = "The rolling update policy. https://www.terraform.io/docs/providers/google/r/compute_region_instance_group_manager#rolling_update_policy"
   type = list(object({
-    max_surge_fixed                = number
-    instance_redistribution_type   = string
-    max_surge_percent              = number
-    max_unavailable_fixed          = number
-    max_unavailable_percent        = number
-    min_ready_sec                  = number
-    replacement_method             = string
+    max_surge_fixed                = optional(number)
+    instance_redistribution_type   = optional(string)
+    max_surge_percent              = optional(number)
+    max_unavailable_fixed          = optional(number)
+    max_unavailable_percent        = optional(number)
+    min_ready_sec                  = optional(number)
+    replacement_method             = optional(string)
     minimal_action                 = string
     type                           = string
-    most_disruptive_allowed_action = string
+    most_disruptive_allowed_action = optional(string)
   }))
   default = []
 }

modules/mig_with_percent/versions.tf

@@ -15,7 +15,7 @@
  */
 
 terraform {
-  required_version = ">=0.13.0"
+  required_version = ">=1.3.0"
   required_providers {
     google = {
       source  = "hashicorp/google"