Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add connection metadata, metadata.display.yaml #439

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Oct 16, 2024

This PR updates connection metadata for instance_template and mig modules. It also makes scope field of service_account variable of instance_template as optional with default value of ["cloud-platform"]

@q2w q2w force-pushed the master branch 2 times, most recently from b7d7737 to 6fe85d3 Compare October 16, 2024 19:23
@q2w q2w marked this pull request as ready for review October 16, 2024 19:34
@q2w q2w requested a review from a team as a code owner October 16, 2024 19:34
Copy link

@qz267 qz267 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@q2w q2w requested a review from bharathkkb October 21, 2024 18:16
@q2w q2w requested a review from erlanderlo as a code owner October 21, 2024 18:16
@q2w q2w enabled auto-merge (squash) October 22, 2024 10:54
@q2w q2w merged commit 8cc5f65 into terraform-google-modules:master Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants