Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Function for automatic folder inclusion: improvements #14

Open
7 tasks
nick4fake opened this issue Sep 10, 2019 · 4 comments
Open
7 tasks

Cloud Function for automatic folder inclusion: improvements #14

nick4fake opened this issue Sep 10, 2019 · 4 comments
Assignees
@nick4fake
Labels
enhancement New feature or request P4 low priority issues triaged Scoped and ready for work

Comments

@nick4fake
Copy link
Contributor

nick4fake commented Sep 10, 2019 •
edited by morgante
Loading

Follow up of Cloud Function for automatic folder inclusion

Nice to have:

  • Add tests
  • Failure notifications
  • Switch to a native Go library to make terraform a native dependency
  • Retries for cloud function
  • Add support for subfolders
  • Reduce function code zip file
  • Possibly simplify whole approach
@morgante morgante reopened this Sep 10, 2019
@morgante
Copy link
Contributor

I've prioritized the items above.

nick4fake added a commit to nick4fake/terraform-google-vpc-service-controls that referenced this issue Sep 11, 2019
@nick4fake
Fixes terraform-google-modules#11: Cloud Function for automatic folde…
36626c8 
…r inclusion

terraform-google-modules#11
terraform-google-modules#14

Added example with cloud function that automatically runs TF when
project is created/moved/deleted.
@nick4fake
Copy link
Contributor Author

@morgante
image

nick4fake added a commit to nick4fake/terraform-google-vpc-service-controls that referenced this issue Sep 12, 2019
@nick4fake
Fixes terraform-google-modules#11: Cloud Function for automatic folde…
a4e9c77 
…r inclusion

terraform-google-modules#11
terraform-google-modules#14

Added example with cloud function that automatically runs TF when
project is created/moved/deleted.
@aaron-lane aaron-lane added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Sep 16, 2019
@morgante morgante mentioned this issue Sep 17, 2019
Merged
10 tasks
@morgante
Copy link
Contributor

Moved TODO to #16

nick4fake added a commit to nick4fake/terraform-google-vpc-service-controls that referenced this issue Sep 18, 2019
@nick4fake
Fixes terraform-google-modules#11: Cloud Function for automatic folde…
4231015 
…r inclusion

terraform-google-modules#11
terraform-google-modules#14

Added example with cloud function that automatically runs TF when
project is created/moved/deleted.
@morgante
Copy link
Contributor

@nick4fake I fixed issue 4 via #18, FYI.

morgante pushed a commit that referenced this issue Sep 20, 2019
@nick4fake @morgante
Fixes #11: Cloud Function for automatic folder inclusion
dc50277 
#11
#14

Added example with cloud function that automatically runs TF when
project is created/moved/deleted.
@morgante morgante reopened this Sep 23, 2019
@aaron-lane aaron-lane added the P4 low priority issues label Dec 2, 2019
@aaron-lane aaron-lane added the triaged Scoped and ready for work label Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nick4fake nick4fake

Labels
enhancement New feature or request P4 low priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nick4fake @morgante @aaron-lane