fix(TPG >= 4.68)!: added missing features for egress policies #131
+43
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imrannayer
reviewed
Feb 6, 2024
imrannayer
reviewed
Feb 6, 2024
imrannayer
changed the title
chore: update .github/workflows/stale.yml
|
/gcbrun |
imrannayer
reviewed
Feb 8, 2024
|
/gcbrun |
g-awmalik
reviewed
Feb 9, 2024
| @@ -28,13 +28,15 @@ resource "google_access_context_manager_service_perimeter" "regular_service_peri | |||
|
|
|||
| status { | |||
| restricted_services = var.restricted_services | |||
| resources = [for item in var.resources : can(regex("global/networks", item)) ? format("//compute.googleapis.com/%s", item) : format("projects/%s", item)] | |||
There was a problem hiding this comment.
I think this is adding the resource i.e. the project to the perimeter and then google_access_context_manager_service_perimeter_resource below tries to add it again leading to:
STDERR: Error: Unable to create ServicePerimeterResource, existing object already found: map[resource:projects/838237599229]
with module.example.module.regular_service_perimeter_1.google_access_context_manager_service_perimeter_resource.service_perimeter_resource["838237599229"],
on ../../../modules/regular_service_perimeter/main.tf line 229, in resource "google_access_context_manager_service_perimeter_resource" "service_perimeter_resource":
229: resource "google_access_context_manager_service_perimeter_resource" "service_perimeter_resource" {
---- End output of terraform apply -auto-approve -lock=true -lock-timeout=0s -input=false -no-color -paral
There was a problem hiding this comment.
@cmalpe can u plz remove resource = ....
There was a problem hiding this comment.
This change is done @imrannayer
|
/gcbrun |
imrannayer
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.