Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark secret outputs sensitive for classic vpn Ref: #158 #159

Conversation

qbaze
Copy link
Contributor

@qbaze qbaze commented May 21, 2024

No description provided.

@qbaze qbaze requested review from imrannayer and a team as code owners May 21, 2024 10:23
Copy link

google-cla bot commented May 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@imrannayer
Copy link
Collaborator

imrannayer commented May 22, 2024

@qbaze have you tried setting these outputs sensitive in your root module code?

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@qbaze
Copy link
Contributor Author

qbaze commented Jul 23, 2024

@imrannayer sorry for a late response

when used as a submodule it works fine but isn't it to work also as a standalone one?

are there any cons marking these sensitive in its own outputs?

@imrannayer
Copy link
Collaborator

imrannayer commented Jul 23, 2024

@qbaze these are published as modules. Expectation is they will be used as module.

@imrannayer
Copy link
Collaborator

/gcbrun

@bharathkkb bharathkkb closed this Jul 23, 2024
@bharathkkb bharathkkb reopened this Jul 23, 2024
@bharathkkb
Copy link
Member

/gcbrun

@imrannayer imrannayer self-assigned this Jul 23, 2024
@imrannayer imrannayer merged commit c3c7812 into terraform-google-modules:master Jul 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants