terraformrules: Get module contents with IncludeNotCreated: true (#…

…1458)
terraform-linters · Jul 29, 2022 · c40ee70 · c40ee70
1 parent 36628eb
commit c40ee70
Show file tree

Hide file tree

Showing 13 changed files with 32 additions and 13 deletions.
diff --git a/rules/terraformrules/terraform_documented_outputs.go b/rules/terraformrules/terraform_documented_outputs.go
@@ -57,7 +57,7 @@ func (r *TerraformDocumentedOutputsRule) Check(runner *tflint.Runner) error {
 				},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}

diff --git a/rules/terraformrules/terraform_documented_variables.go b/rules/terraformrules/terraform_documented_variables.go
@@ -57,7 +57,7 @@ func (r *TerraformDocumentedVariablesRule) Check(runner *tflint.Runner) error {
 				},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}

diff --git a/rules/terraformrules/terraform_module_pinned_source.go b/rules/terraformrules/terraform_module_pinned_source.go
@@ -66,7 +66,7 @@ func (r *TerraformModulePinnedSourceRule) Check(runner *tflint.Runner) error {
 		return err
 	}
 
-	body, diags := runner.GetModuleContent(moduleCallSchema, sdk.GetModuleContentOption{})
+	body, diags := runner.GetModuleContent(moduleCallSchema, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}

diff --git a/rules/terraformrules/terraform_module_version.go b/rules/terraformrules/terraform_module_version.go
@@ -62,7 +62,7 @@ func (r *TerraformModuleVersionRule) Check(runner *tflint.Runner) error {
 		return err
 	}
 
-	body, diags := runner.GetModuleContent(moduleCallSchema, sdk.GetModuleContentOption{})
+	body, diags := runner.GetModuleContent(moduleCallSchema, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}

diff --git a/rules/terraformrules/terraform_naming_convention.go b/rules/terraformrules/terraform_naming_convention.go
@@ -123,7 +123,7 @@ func (r *TerraformNamingConventionRule) Check(runner *tflint.Runner) error {
 				Body:       &hclext.BodySchema{},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}

diff --git a/rules/terraformrules/terraform_required_providers.go b/rules/terraformrules/terraform_required_providers.go
@@ -61,7 +61,7 @@ func (r *TerraformRequiredProvidersRule) Check(runner *tflint.Runner) error {
 				},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}
@@ -102,7 +102,7 @@ func (r *TerraformRequiredProvidersRule) Check(runner *tflint.Runner) error {
 				},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}

diff --git a/rules/terraformrules/terraform_required_version.go b/rules/terraformrules/terraform_required_version.go
@@ -55,7 +55,7 @@ func (r *TerraformRequiredVersionRule) Check(runner *tflint.Runner) error {
 				},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}

diff --git a/rules/terraformrules/terraform_standard_module_structure.go b/rules/terraformrules/terraform_standard_module_structure.go
@@ -67,7 +67,7 @@ func (r *TerraformStandardModuleStructureRule) Check(runner *tflint.Runner) erro
 				Body:       &hclext.BodySchema{},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}

diff --git a/rules/terraformrules/terraform_typed_variables.go b/rules/terraformrules/terraform_typed_variables.go
@@ -56,7 +56,7 @@ func (r *TerraformTypedVariablesRule) Check(runner *tflint.Runner) error {
 				},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}

diff --git a/rules/terraformrules/terraform_unused_declaration.go b/rules/terraformrules/terraform_unused_declaration.go
@@ -109,7 +109,7 @@ func (r *TerraformUnusedDeclarationsRule) declarations(runner *tflint.Runner) (*
 				Body:       &hclext.BodySchema{},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return decl, diags
 	}

diff --git a/rules/terraformrules/terraform_unused_required_providers_test.go b/rules/terraformrules/terraform_unused_required_providers_test.go
@@ -239,6 +239,25 @@ func Test_TerraformUnusedRequiredProvidersRule(t *testing.T) {
 				},
 			},
 		},
+		{
+			Name: "used - unevaluated resource",
+			Content: `
+				terraform {
+					required_providers {
+						null = {
+							source = "hashicorp/null"
+						}
+					}
+				}
+
+				variable "foo" {}
+
+				resource "null_resource" "foo" {
+					count = var.foo
+				}
+			`,
+			Expected: tflint.Issues{},
+		},
 	}
 
 	rule := NewTerraformUnusedRequiredProvidersRule()

diff --git a/rules/terraformrules/terraform_workspace_remote.go b/rules/terraformrules/terraform_workspace_remote.go
@@ -64,7 +64,7 @@ func (r *TerraformWorkspaceRemoteRule) Check(runner *tflint.Runner) error {
 				},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return diags
 	}

diff --git a/rules/terraformrules/utils.go b/rules/terraformrules/utils.go
@@ -155,7 +155,7 @@ func getProviderRefs(runner *tflint.Runner) (map[string]*providerRef, hcl.Diagno
 				},
 			},
 		},
-	}, sdk.GetModuleContentOption{})
+	}, sdk.GetModuleContentOption{IncludeNotCreated: true})
 	if diags.HasErrors() {
 		return providerRefs, diags
 	}