-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to pass tags as parameter to apply to aws resources #10
base: main
Are you sure you want to change the base?
Conversation
@bardielle @gdbranco would you mind reviewing this PR? thank you! |
@bardielle thank you for the review. updated as suggested. |
@gdbranco please review it also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Lets have jira ticket prefixing the title |
@bardielle @romfreiman just checking to see if there is anything needed on this to approve merge? |
@arendej asked to discuss this PR on our next sync meeting.
I will update you @vamsinm with the conclusions |
thank you @bardielle ! this merge request does not refer any OCM resources. this terrafrom module is only generating AWS resources. is there a plan to include OCM resources in here? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
when using terraform module the resources created will not have any resource tags. in most cases organizations need certain mandatory tagging for billing or categorizng resources to particular application or team. this PR will in clude tags as parameter so they can be passed to module.
#8