Skip to content

Conversation

ironcladlou
Copy link

🚧 WIP 🚧

Before this commit, the modules made two assumptions which prevented creation of HCP clusters on ROSA GovCloud:

  1. ARN formats hard-coded the AWS partition
  2. The rhcs_cluster_rosa_hcp module always set a billing account ID, which should always be empty for GovCloud HCP clusters.

This commit makes ARN partition segments dynamic with regards to the current AWS account, and sets a null billing account ID when targeting GovCloud. The result is HCP clusters can be successfully created on ROSA GovCloud.

TODO: This depends on a new provider version which includes:

Before this commit, the modules made two assumptions which prevented creation
of HCP clusters on ROSA GovCloud:

1. ARN formats hard-coded the AWS partition
2. The `rhcs_cluster_rosa_hcp` module always set a billing account ID, which should
   always be empty for GovCloud HCP clusters.

This commit makes ARN partition segments dynamic with regards to the current AWS
account, and sets a `null` billing account ID when targeting GovCloud. The result
is HCP clusters can be successfully created on ROSA GovCloud.

TODO: This depends on a new provider version which includes:

- terraform-redhat/terraform-provider-rhcs#946
- terraform-redhat/terraform-provider-rhcs#947
Copy link

openshift-ci bot commented Aug 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ironcladlou
Once this PR has been reviewed and has the lgtm label, please assign nirarg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 8, 2025

Hi @ironcladlou. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants