Skip to content

Conflate duplicated unit tests #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

Conflate duplicated unit tests #4399

merged 1 commit into from
Oct 9, 2025
+133 −43

Conversation

@sdobbert
Copy link
Contributor

@sdobbert sdobbert commented Oct 2, 2025

Description

This PR joins Unittests from #4394 and #4379 since they were dublicated.

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm run check locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@sdobbert sdobbert mentioned this pull request Oct 2, 2025
Open
15 tasks
@dnlkoch dnlkoch changed the title fix: Conflate dublicated Unittests Conflate duplicated unit tests Oct 6, 2025
marcjansen
marcjansen approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Please merge.

@sdobbert sdobbert merged commit a7f20aa into main Oct 9, 2025
2 checks passed
@dnlkoch
Copy link
Member

dnlkoch commented Oct 9, 2025

🎉 This PR is included in version 32.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcjansen marcjansen marcjansen approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sdobbert @dnlkoch @marcjansen