Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt column name for MS SQLServer compatibility #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adapt column name for MS SQLServer compatibility #54

wants to merge 1 commit into from

Conversation

buehner
Copy link
Member

@buehner buehner commented Jul 30, 2014

KEY seems to be a reserved word in SQLServer, so hibernate could not create the schema correctly.

Please review and merge!

@buehner
Adapt column name for MS SQLServer compatibility
23f1d45 
KEY seems to be a reserved word in SQLServer, so hibernate could not create the schema correctly.
@chrismayer
Copy link
Collaborator

Hi @buehner ,
since this only changes the DB itself and it does not affect any other components becuse of the mapping feel free to merge!
Thank you!

@marcjansen
Copy link
Member

What does this mean if someone updated an existing SHOGun to use this new mapping?

Will hbm2ddl=UPDATE work and rename the column? I am unsure about whether we want to merge this.

@chrismayer
Copy link
Collaborator

Oh yes, @marcjansen good point, haven't thought about this.
I am also unsure if hbm2ddl=UPDATE will do the stuff for you. Maybe we need a kind of update strategy or a kind of mapping so both column names can work (did not investigate if there is something offering such a mapping)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buehner @chrismayer @marcjansen