-
-
Notifications
You must be signed in to change notification settings - Fork 591
[Test] deps(compose): use compose v5 #3490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary by CodeRabbit
WalkthroughThe PR updates the docker/compose module dependency from v2.40.2 to v5.0.0-rc.2, updating all corresponding import paths from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
modules/compose/go.sumis excluded by!**/*.sum
📒 Files selected for processing (5)
Makefile(1 hunks)modules/compose/compose.go(1 hunks)modules/compose/compose_api.go(1 hunks)modules/compose/compose_api_test.go(1 hunks)modules/compose/go.mod(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-18T08:24:27.479Z
Learnt from: mdelapenya
Repo: testcontainers/testcontainers-go PR: 3254
File: .github/dependabot.yml:21-21
Timestamp: 2025-09-18T08:24:27.479Z
Learning: In the testcontainers-go repository, submodules like atlaslocal that are part of a parent module (e.g., mongodb) share the same go.mod file and should not have separate Dependabot entries. They are already monitored through the parent module's Dependabot configuration entry.
Applied to files:
modules/compose/go.mod
🔇 Additional comments (4)
modules/compose/compose_api.go (1)
19-19: Import path correctly updated to v5.The import path change aligns with the PR's objective to migrate to Compose SDK v5.
Makefile (1)
70-70: Makefile replace directive correctly updated to v5.The compose-replace target now correctly references v5, which is consistent with the migration.
modules/compose/compose_api_test.go (1)
13-13: Test import path correctly updated to v5.The import path change in tests is consistent with the v5 migration.
modules/compose/compose.go (1)
15-16: Import paths correctly updated to v5.Both API and compose package imports have been properly updated to v5.
Signed-off-by: Nicolas De Loof <[email protected]>
What does this PR do?
use compose SDK (docker/compose/v5)
This is a sanity-check PR before compose v5.0.0 release
Why is it important?
This is the first release with official SDK support