Skip to content

Conversation

@ndeloof
Copy link

@ndeloof ndeloof commented Nov 13, 2025

What does this PR do?

use compose SDK (docker/compose/v5)
This is a sanity-check PR before compose v5.0.0 release

Why is it important?

This is the first release with official SDK support

@ndeloof ndeloof requested a review from a team as a code owner November 13, 2025 08:53
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit e569518
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-go/deploys/6915a13ba799560008d42188
😎 Deploy Preview https://deploy-preview-3490--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Nov 13, 2025

Summary by CodeRabbit

  • Chores
    • Updated Docker Compose dependency from version 2 to version 5 to ensure compatibility with the latest upstream releases. No breaking changes to existing functionality.

Walkthrough

The PR updates the docker/compose module dependency from v2.40.2 to v5.0.0-rc.2, updating all corresponding import paths from docker/compose/v2 to docker/compose/v5 across Go source files, tests, and the Makefile.

Changes

Cohort / File(s) Summary
Import path updates
modules/compose/compose.go, modules/compose/compose_api.go, modules/compose/compose_api_test.go
Updated docker/compose import paths from v2 to v5 across multiple modules
Dependency version
modules/compose/go.mod
Bumped docker/compose dependency from v2.40.2 to v5.0.0-rc.2
Build configuration
Makefile
Updated compose-replace target to reference docker/compose v5 instead of v2

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • All changes follow a consistent v2-to-v5 upgrade pattern with no logic modifications
  • Limited scope across imports and version specifications
  • Key area for attention: verify compatibility between v2.40.2 and v5.0.0-rc.2; ensure no breaking API changes in the docker/compose package that could affect downstream behavior

Suggested labels

dependencies, compose

Poem

🐰 From v2 to v5, the compose module takes flight,
Import paths refreshed, dependencies polished bright,
A simple hop upward in versions divine,
The rabbit approves—all updates align! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'use compose v5' accurately reflects the main change: upgrading docker/compose from v2 to v5 across all module files and dependencies.
Description check ✅ Passed The pull request description clearly explains the changes (updating to compose v5 SDK) and provides relevant context about why it matters (first official SDK release).
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec51c67 and b01d5ae.

⛔ Files ignored due to path filters (1)
  • modules/compose/go.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • Makefile (1 hunks)
  • modules/compose/compose.go (1 hunks)
  • modules/compose/compose_api.go (1 hunks)
  • modules/compose/compose_api_test.go (1 hunks)
  • modules/compose/go.mod (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-18T08:24:27.479Z
Learnt from: mdelapenya
Repo: testcontainers/testcontainers-go PR: 3254
File: .github/dependabot.yml:21-21
Timestamp: 2025-09-18T08:24:27.479Z
Learning: In the testcontainers-go repository, submodules like atlaslocal that are part of a parent module (e.g., mongodb) share the same go.mod file and should not have separate Dependabot entries. They are already monitored through the parent module's Dependabot configuration entry.

Applied to files:

  • modules/compose/go.mod
🔇 Additional comments (4)
modules/compose/compose_api.go (1)

19-19: Import path correctly updated to v5.

The import path change aligns with the PR's objective to migrate to Compose SDK v5.

Makefile (1)

70-70: Makefile replace directive correctly updated to v5.

The compose-replace target now correctly references v5, which is consistent with the migration.

modules/compose/compose_api_test.go (1)

13-13: Test import path correctly updated to v5.

The import path change in tests is consistent with the v5 migration.

modules/compose/compose.go (1)

15-16: Import paths correctly updated to v5.

Both API and compose package imports have been properly updated to v5.

mdelapenya
mdelapenya previously approved these changes Nov 13, 2025
@mdelapenya mdelapenya changed the title use compose v5 deps(compose): use compose v5 Nov 13, 2025
Signed-off-by: Nicolas De Loof <[email protected]>
@ndeloof ndeloof marked this pull request as draft November 13, 2025 09:13
@ndeloof ndeloof changed the title deps(compose): use compose v5 [Test] deps(compose): use compose v5 Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants