#10775 Implement Valkey module #11101
Open
+474
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwisser
changed the title
rajucomp
reviewed
Oct 13, 2025
|
|
||
| @Override | ||
| public void start() { | ||
| List<String> command = new ArrayList<>(); |
There was a problem hiding this comment.
nit: This should be final.
There was a problem hiding this comment.
I'm not a fan of this because excessive usage of final in Java clutters the code and worsens readability. It's pretty uncommon and I don't see a presence of this convention in the codebase either.
I'm happy to discuss it, but contribution guidelines state we should adapt to code base standards.
rajucomp
reviewed
Oct 13, 2025
modules/valkey/src/main/java/org/testcontainers/valkey/ValkeyContainer.java
Outdated
Show resolved
Hide resolved
rajucomp
reviewed
Oct 13, 2025
modules/valkey/src/main/java/org/testcontainers/valkey/ValkeyContainer.java
Show resolved
Hide resolved
rajucomp
reviewed
Oct 13, 2025
modules/valkey/src/test/java/org/testcontainers/valkey/ValkeyContainerTest.java
Outdated
Show resolved
Hide resolved
rajucomp
reviewed
Oct 13, 2025
modules/valkey/src/test/java/org/testcontainers/valkey/ValkeyContainerTest.java
Outdated
Show resolved
Hide resolved
rajucomp
reviewed
Oct 13, 2025
|
|
||
| @Test | ||
| void shouldMountValkeyConfigToContainer() throws Exception { | ||
| Path configFile = Paths.get(getClass().getResource("/valkey.conf").toURI()); |
There was a problem hiding this comment.
Variables that do not change state after declaration should be explicitly marked as final.
rajucomp
reviewed
Oct 13, 2025
modules/valkey/src/test/java/org/testcontainers/valkey/ValkeyContainerTest.java
Outdated
Show resolved
Hide resolved
…cution; utilize AutoCloseable iface in tests; make use of StringUtils.isNotEmpty for preconditions
rajucomp
reviewed
Oct 13, 2025
modules/valkey/src/main/java/org/testcontainers/valkey/ValkeyContainer.java
Outdated
Show resolved
Hide resolved
rajucomp
reviewed
Oct 13, 2025
modules/valkey/src/main/java/org/testcontainers/valkey/ValkeyContainer.java
Outdated
Show resolved
Hide resolved
rajucomp
reviewed
Oct 13, 2025
modules/valkey/src/main/java/org/testcontainers/valkey/ValkeyContainer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #10775, this PR will add support for Valkey testcontainers similar as we already have them for Node, Go & Rust.
I've included most of the features that currently supporting languages have such as:
Ready to accept connections