Fix page breaks inside gigs. #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed page breaks appearing inside of gig listings. The breaks were separating places of employment and job titles from descriptions and highlights.
agent-0028
reviewed
Mar 12, 2018
| @@ -104,7 +107,7 @@ section | |||
| text-align: left | |||
|
|
|||
| .block | |||
| page-break-inside: avoid | |||
| break-inside: avoid | |||
There was a problem hiding this comment.
What's the skinny in preferring break-inside over page-break-inside? I just skimmed the spec, I am guessing you like it better because it is less specific to print media?
| @@ -75,6 +75,9 @@ section | |||
| .category | |||
| margin-left: 1in | |||
|
|
|||
| .gig | |||
| break-inside: avoid | |||
There was a problem hiding this comment.
I played with something similar, but now that I have added a projects array to my Test Double gig, it is being pushed off the front page.
I am going to hold off on a PR about this until this is merged or closed or we get a chance to pair on it.
I love the way cobbler works, but making a printable paged document from HTML ls always a headache.
I have some ideas, but I will express them in code when/if I have a chance to work on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes page breaks separating gig titles from content.
Original
Fix