Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript typing thenResolve takes variable args #258

Merged
merged 3 commits into from
Jun 18, 2017

Conversation

miyu
Copy link
Contributor

@miyu miyu commented Jun 13, 2017

For consistency with thenReturn - no changes to library necessary.

@searls
Copy link
Member

searls commented Jun 13, 2017

Build failure was erroneous. Restarted.

@duluca will merge if you approve change

@duluca
Copy link
Contributor

duluca commented Jun 14, 2017

It'd be great if this PR is updated once #260 is merged, so there's a valid CI run against this change.

TODO:
[ ] Update from master once #260 is merged
[ ] Add a line to test.ts that exercises the spread feature
[ ] Update this PR and make sure CI checks pass

@searls
Copy link
Member

searls commented Jun 14, 2017

ok @duluca, #260 (nay #259) is now merged, so this should be doable now.

@miyu
Copy link
Contributor Author

miyu commented Jun 14, 2017

Merged #260, changed test.ts. I figure if the spread case is covered the one-arg case is covered?

@duluca
Copy link
Contributor

duluca commented Jun 14, 2017

@miyu I concur

@searls
Copy link
Member

searls commented Jun 14, 2017

Stupid Q: does thenResolve() actually support multiple promises? I don't think we have a test for this in test/src/when-test.coffee. Can you validate for me?

@miyu
Copy link
Contributor Author

miyu commented Jun 15, 2017

I'm using thenResolve(a, b) in my own tests.

@searls
Copy link
Member

searls commented Jun 18, 2017

Sure enough. I added some tests for this to ensure I don't break you in #263

@searls searls merged commit e7cf045 into testdouble:master Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants