Include roles from shadowDOM in Error message #999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds a check which improves Error messages for folks testing Web Components using
getByRole
.Note: This PR is focused on getting a correct Error message and not a passing test. This fix will be most useful to folks using
dom-testing-library
in conjunction with the wrapper library referenced in this comment in #413.Why:
When testing Web Components the returned error is incorrect. The example below walks you through this case.
Contents of the shadowDOM for
<custom-button>
Below is a test assertion with a minor typo in it.
Before the change in this PR the error message returned is:
After the change the error becomes:
How:
Adds a check for
node.shadowRoot
inflattenDom
to ensurechildren
inside of Web Components are traversed.Checklist:
docs site N/A