Parity with testium-driver-sync #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 23, 2015 15:57
added 15 commits
October 27, 2015 12:53
| } | ||
|
|
||
| function getterToPropName(propName) { | ||
| return propName.replace(/^get([A-Z])/, secondToLowerCase); |
There was a problem hiding this comment.
Should there be a + or * in there? e.g. /^get([A-Z]+)/
There was a problem hiding this comment.
I'm not sure if getABC should become abc, aBC, or ABC. I'd consider that "undefined behavior". I don't think that's an actual case this function handles. E.g. all properties it's concerned with are the ones provided by webdriver, e.g. getText -> text, getPageTitle -> pageTitle, etc.
|
Nice work! |
jkrems
added a commit
that referenced
this pull request
Oct 29, 2015
Parity with testium-driver-sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browser.getElement: Throws a clean exception if the element doesn't existbrowser.getElementOrNull: Same behavior as-sync'sgetElementsetCookieValueandgetCookieValuefor parity with-sync. Those methods aren't part of-syncbut itssetCookiedefaults topath: '/'which conflicts with howwdworks.Issue outlining where
testium-driver-wd's API differs fromtestium-driver-sync: testiumjs/testium-driver-sync#8