chore: fix some gradle warnings and upgrade plugins version

build-logic/code-quality/build.gradle.kts

@@ -10,7 +10,7 @@ repositories {
 
 dependencies {
     implementation("org.sonarqube:org.sonarqube.gradle.plugin:4.4.1.3373")
-    implementation("com.github.autostyle:autostyle-plugin-gradle:3.2")
+    implementation("com.github.autostyle:autostyle-plugin-gradle:4.0")
 }
 
 tasks.withType<KotlinCompile>().configureEach {

build-logic/publishing/src/main/kotlin/buildlogic/FirstLayerDependencies.kt

@@ -9,6 +9,7 @@ import org.gradle.api.artifacts.result.UnresolvedDependencyResult
 import org.gradle.api.plugins.ExtensionAware
 import org.gradle.api.plugins.JavaPluginExtension
 import org.gradle.kotlin.dsl.the
+import java.util.*
 
 /**
  * Walks over the dependency tree and selects the first non-shaded dependencies.
@@ -57,7 +58,8 @@ fun Project.firstLayerDependencies(
     vararg rest: Configuration,
 ): Configuration {
     val optionalFeatures = (the<JavaPluginExtension>() as ExtensionAware).the<OptionalFeaturesExtension>()
-    val usageKind = usage.removePrefix("java-").capitalize()
+    val usageKind = usage.removePrefix("java-")
+        .replaceFirstChar { if (it.isLowerCase()) it.titlecase(Locale.getDefault()) else it.toString() }
 
     val allDependencies = configurations.create(conf.name + "${usageKind}AllDependencies") {
         description = "Resolves the list of all dependencies for $usage in ${conf.name}"

gradle.properties

@@ -1,5 +1,4 @@
 org.gradle.parallel=true
-systemProp.org.gradle.kotlin.dsl.precompiled.accessors.strict=true
 kotlin.code.style=official
 # See https://kotlinlang.org/docs/gradle.html#dependency-on-the-standard-library
 # Note: testng.kotlin-library.gradle.kts adds kotlin-stdlib for testImplementation
@@ -21,3 +20,7 @@ scm.url=https\://github.com/testng-team/testng.git
 nexus.profile=org.testng
 github.organization=testng-team
 github.repository=testng
+
+# Fix Gradle warning with sonarqube plugin v4.x
+# See https://community.sonarsource.com/t/sonarscanner-for-gradle-you-can-now-decide-when-to-compile/102069
+systemProp.sonar.gradle.skipCompile=true

testng-test-osgi/testng-test-osgi-build.gradle.kts

@@ -38,7 +38,7 @@ val depDir = layout.buildDirectory.dir("pax-dependencies")
 
 val generateDependenciesProperties by tasks.registering(WriteProperties::class) {
     description = "Generates dependencies.properties so pax-exam can use .versionAsInProject()"
-    setOutputFile(depDir.map { it.file("META-INF/maven/dependencies.properties") })
+    destinationFile.set(depDir.map { it.file("META-INF/maven/dependencies.properties") })
     property("groupId", project.group)
     property("artifactId", project.name)
     property("version", project.version)
@@ -49,7 +49,7 @@ val generateDependenciesProperties by tasks.registering(WriteProperties::class)
         configurations.testRuntimeClasspath.get().resolvedConfiguration.resolvedArtifacts.forEach {
             val prefix = "${it.moduleVersion.id.group}/${it.moduleVersion.id.name}"
             property("$prefix/scope", "compile")
-            property("$prefix/type", it.extension)
+            property("$prefix/type", it.extension.orEmpty())
             property("$prefix/version", it.moduleVersion.id.version)
         }
     }