-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(t8s-cluster): prepare for flux drift-detection #322
Conversation
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
Code-Changes look good to me. However I don't get the correlation to flux drift-detection. Maybe a more verbose description would help? |
Ah, sorry, must've got lost, I meant to refer to the new flux feature |
I do get, what drift detection is. I also do approve choosing a bigger interval for helm-releases. Especially since 1m is pretty fast. What I don't get is, what's the connection between longer intervals and drift detection. To me, these are two independent things. |
Currently the interval doesn't do anything, therefore even This of course causes semi-high load. And as we don't really expect there to be many random deletion / changes of the created resources it's good to have a semi-long interval as not to overload flux. |
You mean because the drift detection would do the dry-run on every reconcile? Changes look good to me 👍 |
Ah, see. That's what I mean by a more verbose description. This really helps understanding the relevance of these changes. LGTM |
No description provided.