Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configdialog: Move option 'Show preview on formulas' to Adv. Editor #3380

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

octaeder
Copy link
Contributor

This PR resolves #3379.

@sunderme
Copy link
Member

it needs to say that it affect tooltip review on formulas. Other previews work independently ...

@octaeder
Copy link
Contributor Author

So this?
Note: Even if the preview display mode is set to Inline, a tooltip is used to preview formulas.

@octaeder
Copy link
Contributor Author

Maybe you mean the option text. In fact the option affects preview by hovering the mouse. Another preview exists for selections/parentheses. It seems a bit cumbersome to point this out in the option text.

@octaeder
Copy link
Contributor Author

What I mean is, that by hovering the mouse the preview could be in the preview pane or in the pdf viewer for ex. So there is no tooltip at all.

@sunderme
Copy link
Member

the main text <string>Show preview on formulas</string> was changed from <string>Show preview as tooltip on formulas in editor</string> and I don't see a reason why ?

@octaeder
Copy link
Contributor Author

If you set this option and set Preview Display Mode to say pdf viewer there will be no tooltip. If you unset the option there will be no tooltip and no other preview. So why should there be "tooltip"?

@sunderme
Copy link
Member

we can continue once 4.7.0 is released.

@bala
Copy link

bala commented Nov 20, 2023

@sunderme will 4.7.0 be published to ubuntu ppa for jammy immediately?

@sunderme
Copy link
Member

When 4.7.0 is released, it will be published on ppa.

@octaeder
Copy link
Contributor Author

If we agree that this option may show something other than a tooltip, but even so you wish to keep the option text, this is no problem. Then I can revert the text change. So let me know.

@sunderme
Copy link
Member

yes, keeping the original text is the idea. The main point is that it works for hover and by default tooltips are shown.

@octaeder
Copy link
Contributor Author

Show preview as tooltip on formulas in editor: keep in editor? we are in Adv. Editor section.

@sunderme
Copy link
Member

if "in editor" is kept, no new translations are needed, so that is a plus.

@octaeder
Copy link
Contributor Author

image

@sunderme
Copy link
Member

looks okay

@octaeder
Copy link
Contributor Author

octaeder commented Nov 27, 2023

I already committed, but I see on Git for a while:
image

@sunderme
Copy link
Member

I will pull after the release of 4.7.0 any way.

@octaeder octaeder force-pushed the moveOptionPreviewFormulas branch from ba0d286 to 1a67c82 Compare November 27, 2023 20:27
@sunderme sunderme merged commit db428d2 into texstudio-org:master Dec 2, 2023
6 checks passed
@sunderme
Copy link
Member

sunderme commented Dec 2, 2023

by the way, Note: Even if the preview display mode is set to Inline, a tooltip is used. does not make much sense in the context where the option is placed now.

@octaeder octaeder deleted the moveOptionPreviewFormulas branch December 2, 2023 17:00
@octaeder
Copy link
Contributor Author

octaeder commented Dec 2, 2023

change to?
"When the Preview Display Mode is changed, the tooltip text is displayed accordingly (but for Inline it's still a tooltip)."

@sunderme
Copy link
Member

sunderme commented Dec 2, 2023

I think there is no need to have a note here.
It is rather for where the mode is actually changed.

@octaeder
Copy link
Contributor Author

octaeder commented Dec 2, 2023

image
Like this, text ok?

@sunderme
Copy link
Member

sunderme commented Dec 2, 2023

this make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move option "Show Preview ... on Formulas" to Adv. Editor
3 participants