-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configdialog: Move option 'Show preview on formulas' to Adv. Editor #3380
Configdialog: Move option 'Show preview on formulas' to Adv. Editor #3380
Conversation
it needs to say that it affect tooltip review on formulas. Other previews work independently ... |
So this? |
Maybe you mean the option text. In fact the option affects preview by hovering the mouse. Another preview exists for selections/parentheses. It seems a bit cumbersome to point this out in the option text. |
What I mean is, that by hovering the mouse the preview could be in the preview pane or in the pdf viewer for ex. So there is no tooltip at all. |
the main text |
If you set this option and set Preview Display Mode to say pdf viewer there will be no tooltip. If you unset the option there will be no tooltip and no other preview. So why should there be "tooltip"? |
we can continue once 4.7.0 is released. |
@sunderme will 4.7.0 be published to ubuntu ppa for jammy immediately? |
When 4.7.0 is released, it will be published on ppa. |
If we agree that this option may show something other than a tooltip, but even so you wish to keep the option text, this is no problem. Then I can revert the text change. So let me know. |
yes, keeping the original text is the idea. The main point is that it works for hover and by default tooltips are shown. |
Show preview as tooltip on formulas in editor: keep in editor? we are in Adv. Editor section. |
if "in editor" is kept, no new translations are needed, so that is a plus. |
looks okay |
I will pull after the release of 4.7.0 any way. |
ba0d286
to
1a67c82
Compare
by the way, Note: Even if the preview display mode is set to Inline, a tooltip is used. does not make much sense in the context where the option is placed now. |
change to? |
I think there is no need to have a note here. |
this make sense |
This PR resolves #3379.