Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TexDoc dialog: check all packages option without packages present #3917

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

octaeder
Copy link
Contributor

@octaeder octaeder commented Dec 19, 2024

This PR brings back following functionality (discussion #3478 (comment), lost by 277e8c8): When txs starts without any documents the Package help (TexDoc) dialog should automatically check option all packages. Otherwise you have to do so manually before you can search anything. As a side effect this fixes that the packages list is emtpy although the documentation of a0poster is presented.

@sunderme
Copy link
Member

if you open texsdoc once without a document, the "show all" will stick, even if it was not changed by the user.
I would like to see that the mShowAll is only stored if it was a user choice, i.e. that it was not overriden when there is no package list.

@octaeder
Copy link
Contributor Author

@sunderme Thanks, you may check again.

src/help.cpp Outdated
if (dialog.exec()) {
viewTexdoc(dialog.selectedPackage());
}
mShowAllPackages=dialog.showAllPackages();
if (packages.count()==0) {
mShowAllPackages = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not force mShowAllPackages to false either. It just should not change the previous state which maybe true or false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunderme build is running

@sunderme sunderme merged commit c0ba014 into texstudio-org:master Dec 20, 2024
7 checks passed
@sunderme
Copy link
Member

thanks

@octaeder octaeder deleted the setAllPackages branch December 20, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants