Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add old Rainbow Brackets extension to dev container #10

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

EliahKagan
Copy link
Contributor

@EliahKagan EliahKagan commented Nov 18, 2023

I believe this is an improvement because VS Code's bracket pair colorization feature doesn't apply inside docstrings, and hiss has some doctests whose clarity is improved by colorizing nested matching pairs of parentheses, square brackets, and curly braces.

Unfortunately, this extension is deprecated, based on the erroneous belief that VS Code's bracket pair colorization feature does everything it can (that feature is great overall, especially where performance is concerned, but it does not highlight matching brackets in docstrings). This gives an annoying warning. The warning can be disabled, but not for individual extensions, and re-enabling it is nontrivial. I have no great solution to this. The warning can be dismissed every time VS Code is run, or it can be disabled and a manual check done for deprecated extensions from time to time.

There are non-deprecated VS Code extensions for bracket pair colorization, but all the ones I've found besides this one will either not highlight brackets in docstrings, or identify brackets incorrectly a significant fraction of the time.

References:

Because VS Code's bracket pair colorization feature doesn't apply
inside docstrings, and hiss has some doctests whose clarity is
improved by colorizing nested matching pairs of parentheses, square
brackets, and curly braces.

References:

- https://stackoverflow.com/q/71093558
- microsoft/vscode#146453
- EliahKagan/palgoviz#191
@EliahKagan EliahKagan marked this pull request as ready for review November 18, 2023 16:54
@tfallon0 tfallon0 merged commit 423626c into tfallon0:main Nov 18, 2023
@EliahKagan EliahKagan deleted the brackets branch November 18, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants