Initial transpose table (#22) #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: happy to help with the obsidian plugin development for this as well. I assume we'll need an icon, which would really be the hardest part imo. I tested this through your advanced-tables obsidian plugin, so let me know if you'd like some help with that too. |
mochsner
commented
Nov 1, 2022
There was a problem hiding this comment.
@tgrosinger What additional test cases you'd want to see handled here (e.g. particular chars in header divider, no spacing in cells, etc.)? I wasn't exhaustive for this case to avoid bloat, but happy to add more in. The code is fully working afaik.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tgrosinger it's definitely not the prettiest code (due to the need to ignore the delimiter row on both read and write being quite confusing, but I've been a bit strapped for time recently and haven't been able to dive into this code gain. It works well, so let me know what you think.
The main thing that would really help readability for this is if we could (before any computation) just remove the delimiter row flat out. If you have a decent idea of an approach to do that, I'd love to know how. Alternatively, if you wanted to make any changes in my PR, I've granted you full permissions :)