-
Notifications
You must be signed in to change notification settings - Fork 852
Culling of the second type of item slot defines #16627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-Corps into slot-refactor
While you're poking around in quick equip, could you confirm/deny the following bug report: #16601 (comment) I blame a Xander pr. |
…-Corps into slot-refactor
Im removing the whole holster pref so (unless something changes) |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Holster pref.... |
About The Pull Request
Instead of having both bitfield and non bitfield slot defines, now there are just the bitfield slots.
Also refactored
/datum/outfit
s to use lists to spawn their things instead of doing it all inpost_equip
(this also needs to be done for other weird outfit but not quite types, but I didn't have the stamina for it anymore)DO NOT MERGE THIS UNTIL IT HAS BEEN TEST MERGED FOR A GOOD AMOUNT OF ROUNDS
Why It's Good For The Game
Cleaner code, more simple quick equip preferences. Also this makes outfit code way better to look at.
Changelog
🆑
refactor: Refactored the way things are equipped to slots and slots in general
/:cl: