Skip to content

Culling of the second type of item slot defines #16627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from

Conversation

ivanmixo
Copy link
Contributor

@ivanmixo ivanmixo commented Oct 4, 2024

About The Pull Request

Instead of having both bitfield and non bitfield slot defines, now there are just the bitfield slots.
Also refactored /datum/outfits to use lists to spawn their things instead of doing it all in post_equip (this also needs to be done for other weird outfit but not quite types, but I didn't have the stamina for it anymore)

DO NOT MERGE THIS UNTIL IT HAS BEEN TEST MERGED FOR A GOOD AMOUNT OF ROUNDS

Why It's Good For The Game

Cleaner code, more simple quick equip preferences. Also this makes outfit code way better to look at.

Changelog

🆑
refactor: Refactored the way things are equipped to slots and slots in general
/:cl:

@Looking4bros
Copy link
Contributor

While you're poking around in quick equip, could you confirm/deny the following bug report: #16601 (comment)

I blame a Xander pr.

@ivanmixo ivanmixo marked this pull request as draft October 5, 2024 19:13
@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Oct 7, 2024
@tgstation-server tgstation-server added UI We make things worse, but rounder and removed Merge Conflict Pull request is in a conflicted state with base branch. labels Oct 9, 2024
@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Oct 15, 2024
@github-actions github-actions bot added Merge Conflict Pull request is in a conflicted state with base branch. and removed Merge Conflict Pull request is in a conflicted state with base branch. labels Oct 17, 2024
@tgstation-server tgstation-server removed the Merge Conflict Pull request is in a conflicted state with base branch. label Oct 23, 2024
@ivanmixo
Copy link
Contributor Author

While you're poking around in quick equip, could you confirm/deny the following bug report: #16601 (comment)

I blame a Xander pr.

Im removing the whole holster pref so (unless something changes)

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added Stale Pull request is awaiting delayed author response and may be closed. Merge Conflict Pull request is in a conflicted state with base branch. labels Oct 31, 2024
@github-actions github-actions bot closed this Nov 4, 2024
@ivanmixo ivanmixo deleted the slot-refactor branch December 29, 2024 21:21
@ivanmixo ivanmixo mentioned this pull request Dec 29, 2024
@Looking4bros
Copy link
Contributor

Holster pref....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Conflict Pull request is in a conflicted state with base branch. Stale Pull request is awaiting delayed author response and may be closed. UI We make things worse, but rounder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants