Deployed code #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey doug, first of all, it works right now! However, unfortunately i hadn't pulled your latest stuff, but had started hacking away until the thing did what i needed. So i think this is way, way, way less elegant and significantly more hacky than what you currently have, and previously had, but ended up getting the job done.
Also due to node_modules being gitignored, one fix that isn't visible in the code that i'm currently using for the tracker is this one here, which involved modifying the mailparser.sj file in mailparser in the node_modules directly: jcreigno/nodejs-mail-notifier#43 (comment)
I'd encourage you not to accept this pull request due to how hacky it is, or .. if you did, to put it into a small branch somewhere. Thank you again for all of this!