Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for --grpc-client-tls-secure in query via grpcClientTlsSecure config #227

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ulfmansson
Copy link

  • [X ] I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Added support for --grpc-client-tls-secure in query via grpcClientTlsSecure config

Verification

Run with both grpcClientTlsSecure set and unset

Support for tls secure requests

Signed-off-by: ulfmansson <[email protected]>
Added comment about --grpc-client-tls-secure

Signed-off-by: ulfmansson <[email protected]>
Fixed to follow changelog format

Signed-off-by: ulfmansson <[email protected]>
@metalmatze
Copy link
Contributor

Maybe this can be updated to be closer to this using a boolean?

if tq.config.autoDownsampling then [
  '--query.auto-downsampling',
] else []

Updated to nicer structure after comment in PR

Signed-off-by: ulfmansson <[email protected]>
@ulfmansson
Copy link
Author

Updated according to the comment

@kakkoyun kakkoyun changed the title Patch 1 Added support for --grpc-client-tls-secure in query via grpcClientTlsSecure config Aug 24, 2021
@kakkoyun
Copy link
Member

Shall we rebase this? Then we can proceed.

@alejandrolr
Copy link

Any update on this?

@rgarcia89
Copy link

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants