Remove app.kubernetes.io/version from Router Deployment Selector Labels #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-burt
force-pushed
the
router-selectors
branch
3 times, most recently
from
0534327
to
76f01d2
Compare
Signed-off-by: Michael Burt <[email protected]>
michael-burt
force-pushed
the
router-selectors
branch
from
76f01d2
to
42aa44c
Compare
|
Do we need to update other deployments as well |
This is already configured for the other components: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the selector labels on the Receive Router deployment so that they exclude the version. This fixes a bug where it wasn't possible to upgrade the router version without deleting the deployment due to immutability of selector labels.
Changes
I have removed the
app.kubernetes.io/versionlabel from the Receive Router deployment selectorVerification
I am running this code in my dev environment and it fixes the issue I was experiencing whereby Thanos Receive Router would fail to update when a new version of Thanos is deployed due to immutable selector labels being changed.