Implement delayed name removal #507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SungJin1212
force-pushed
the
Implement-delayed-name-removal
branch
2 times, most recently
from
d1e9466 to
1a8440b
Compare
SungJin1212
force-pushed
the
Implement-delayed-name-removal
branch
2 times, most recently
from
ef07d36 to
6972421
Compare
SungJin1212
force-pushed
the
Implement-delayed-name-removal
branch
4 times, most recently
from
26cb3d5 to
281f83e
Compare
SungJin1212
force-pushed
the
Implement-delayed-name-removal
branch
2 times, most recently
from
46cf211 to
7afd092
Compare
|
@SungJin1212 - Is this change still relevant? Could you please rebase? |
SungJin1212
force-pushed
the
Implement-delayed-name-removal
branch
2 times, most recently
from
0d2ce47 to
e9cecc7
Compare
harry671003
reviewed
Mar 19, 2025
engine/engine.go
Outdated
| step: 0, | ||
| resultSort: noSortResultSort{}, | ||
| scanners: scnrs, | ||
| enableDelayedNameRemoval: e.enableDelayedNameRemoval, |
There was a problem hiding this comment.
nit: Does this look better in QueryOpts?
| @@ -18,7 +18,7 @@ type VectorOperator interface { | |||
| // Series returns all series that the operator will process during Next results. | |||
| // The result can be used by upstream operators to allocate output tables and buffers | |||
| // before starting to process samples. | |||
| Series(ctx context.Context) ([]labels.Labels, error) | |||
| Series(ctx context.Context) ([]promql.Series, error) | |||
There was a problem hiding this comment.
This seems like a big change that could break consumers that extend this package.
Since delayed name removal is experimental, should we wait for it to be stable?
There was a problem hiding this comment.
should we wait for it to be stable
Yeah, we can wait until it is to be stable.
SungJin1212
force-pushed
the
Implement-delayed-name-removal
branch
from
e9cecc7 to
ca272b8
Compare
SungJin1212
force-pushed
the
Implement-delayed-name-removal
branch
2 times, most recently
from
1405e8e to
eacdf5c
Compare
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Implement-delayed-name-removal
branch
from
eacdf5c to
35ae9c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
delayed name removalfeature in the Prometheus.The Prometheus PR: