optimize store gateway bytes limiter reserve with type request #8025
+20
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <[email protected]>
harry671003
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
bytesLimiter.ReserveWithTypeis an interface that can be customized by downstream projects for their own byte limiter implementation.In Cortex, we implmented a token bucket based limiter. We noticed that when calling
indexCache.FetchMultiPostingsand fetching a lot of keys,bytesLimiter.ReserveWithTypecan consume a lot of CPU because our implementation requires holding a lock. This was around 40% of the whole CPU time spent onindexCache.FetchMultiPostings.This can be optimized by calling
bytesLimiter.ReserveWithTypeonly once for the total posting size instead of one call per cached item.Verification
Existing tests should still pass.