query: Add metric to track healthy/unhealthy endpoints #8492
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds
thanos_query_endpoints_countmetric to track healthy and unhealthy endpoints.Use case: when not using strict endpoints, the endpoints will silently go stale and there is no way of knowing if queries/rules are getting wrong/no results (wrong results because the data can be partial with stale endpoints). This metric can be useful to alert on if endpoints become unhealthy (for example load-balancers being down).
If there is some other way to identify such silently failing queries, this PR can be closed in favor of that.
Verification
TestEndpointSetUpdatewas panicking locally even without this change, so I have not written unit tests for this yet.