Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility updates #69

Merged
merged 14 commits into from
Oct 19, 2024
Merged

Accessibility updates #69

merged 14 commits into from
Oct 19, 2024

Conversation

sar-mko
Copy link
Collaborator

@sar-mko sar-mko commented Oct 18, 2024

Description

This branch updates some of our accessibility features, including better labelling, colors contrasts, both font sizes and weight. As well us replicating styles from the home page to the rest of our pages.

  • Updated colors and theme for better contrast
  • Larger and darker/lighter text for easier reading
  • Aria-labels for all of our buttons for users with screen-readers
  • Updates to our default home page when users aren't logged in
  • Better spacing and responsiveness

Related Issue

closes #63 (#35)

Acceptance Criteria

  • All texts are legible against the color of their background
  • All icons are legible against the color of their background
  • All buttons are legible and functional against the color of their background

Type of Changes

Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g., bug fix or enhancement are common ones.

Updates

Before

Screenshot 2024-10-18 at 2 26 04 PM Screenshot 2024-10-18 at 2 26 32 PM

After

Screenshot 2024-10-18 at 2 08 33 PM Screenshot 2024-10-18 at 2 08 47 PM Screenshot 2024-10-18 at 2 07 50 PM Screenshot 2024-10-18 at 2 32 33 PM Screenshot 2024-10-18 at 2 32 47 PM

Testing Steps / QA Criteria

  • Pull from sm-accessibility-updates
  • Check if buttons on navbar, home page, list page work (note: there are some known errors with shareList button)
  • Colors are consistent throughout site
  • Be able to use your keyboard to tab through page in a logical order
  • Home page shows welcome page when not signed in (note: list page does not have a default)

@sar-mko sar-mko requested review from fullybaked, EmmaBin, arandel1 and MarcosPerez16 and removed request for fullybaked October 18, 2024 21:34
Copy link
Collaborator

@arandel1 arandel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!
nit-pick: Submit button is not visible when Adding an item, and similarly, Share button is not visible when sharing a list. This can be fixed by making those buttons text color the darkest green (like the background on the navbar)

Screen Shot 2024-10-18 at 5 28 31 PM - Screen Shot 2024-10-18 at 5 28 45 PM

Copy link

github-actions bot commented Oct 19, 2024

Visit the preview URL for this PR (updated for commit 06804a7):

https://tcl-76-smart-shopping-list--pr69-sm-accessibility-upd-twauktfa.web.app

(expires Sat, 26 Oct 2024 04:44:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 512b1a88be8ae05fd3e727b99332819df760271d

@sar-mko sar-mko merged commit c0181e3 into main Oct 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

35. As a user, I expect an accessible application
3 participants