Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rt buttons #56

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Rt buttons #56

merged 2 commits into from
Oct 8, 2024

Conversation

GrannyYetta
Copy link
Collaborator

Type
Enhancement
Buttons are consistently styled
Forms are consistently styled

Description

A total of five different kinds of buttons in the app were consistently styled to cue the user of their use and execution of their funciton.

Related Issue

Closes #55

Acceptance Criteria

  • "Delete" buttons should look like a little trash can
  • Create buttons should be visually more impactful
  • "Add" button should have a visual cue to signal the adding of an item or a list
  • The "clear" button in the search form should be an icon rather than an "x"

Type of Changes

enhancement and bug fix

Updates

Before

Captura de pantalla 2024-10-06 a la(s) 17 46 53

Captura de pantalla 2024-10-06 a la(s) 17 45 57

Captura de pantalla 2024-10-06 a la(s) 17 46 14

Captura de pantalla 2024-10-06 a la(s) 17 46 32

After

Captura de pantalla 2024-10-06 a la(s) 20 08 47

Captura de pantalla 2024-10-06 a la(s) 20 09 23

Captura de pantalla 2024-10-06 a la(s) 20 09 41

Captura de pantalla 2024-10-06 a la(s) 20 09 58

Testing Steps / QA Criteria

  1. npm start
  2. Sign out
  3. Sign in
  4. Navigate to Home, List and Settings

Copy link

github-actions bot commented Oct 6, 2024

Visit the preview URL for this PR (updated for commit d0eb255):

https://tcl-78-smart-shopping-list--pr56-rt-buttons-ozxclfw5.web.app

(expires Sun, 13 Oct 2024 18:11:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

Copy link
Collaborator

@vivitt vivitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @GrannyYetta ⚡️ The app is looking great, and the icons and buttons are consistent.

Just pointing out a small issue I found that can be addressed in this or a future PR. When you are on the homepage and have many lists, if you want to create a new list, the footer covers the 'Create List' button:

Screen.Recording.2024-10-07.at.21.29.15.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants