-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update color scheme and refactor styles for design uniformity #60
Conversation
…isually consistent. refactor repeated styles into custom classes
Visit the preview URL for this PR (updated for commit 2025a68): https://tcl-78-smart-shopping-list--pr60-el-style-refactor-wj3lz9li.web.app (expires Wed, 16 Oct 2024 17:38:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c781903507c1507075d7a974036959ddeec29c0a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job, Eva! The app certainly looks a great deal better and it works well for me in dark mode.
I do have one suggestion: the sign in button at the beginning is aligned to the left and it is twice in the landing page. I suggest we center it and present it only once rather than twice on the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 💥
The app looks really nice and I love the chosen color scheme.
You did a great work using the @apply
directive to extract classes and also deleting the unused CSS.
I noticed that the navigation bar overlaps with the list when it has many items:
I think this might affect usability and just wanted to make sure you were aware, especially in dark mode where some links may disappear into the item's background color:
Description
New color scheme was implemented into the app design. Styling of various components, such as forms, buttons, listed items etc. was updated to ensure consistent design throughout the app. Some styles that were used repeatedly were moved into custom classes to simplify reusing them and improve the maintainability and readability of the codebase. Old unused stylesheets were deleted. A bug that prevented users to scroll the main content out of the navbar is fixed.
Related Issue
closes #59
closes #58
Acceptance Criteria
Acceptance criteria
Type of Changes
enhancement
Updates
Design for different views
Testing Steps / QA Criteria
npm start
navigate to browser, resize the window to test the app's responsiveness