Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color scheme and refactor styles for design uniformity #60

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

eva-lng
Copy link
Collaborator

@eva-lng eva-lng commented Oct 9, 2024

Description

New color scheme was implemented into the app design. Styling of various components, such as forms, buttons, listed items etc. was updated to ensure consistent design throughout the app. Some styles that were used repeatedly were moved into custom classes to simplify reusing them and improve the maintainability and readability of the codebase. Old unused stylesheets were deleted. A bug that prevented users to scroll the main content out of the navbar is fixed.

Related Issue

closes #59
closes #58

Acceptance Criteria

Acceptance criteria

  • A consistent color scheme is applied across the entire app for both light and dark mode
  • Inconsistent styles are adjusted to ensure uniformity in design in all components and pages
  • Repeated styles are refactored into custom classes to ensure easier maintainability and readability of code
  • Any styling issues negatively impacting the user experience should be resolved

Type of Changes

enhancement

Updates

Design for different views

Screenshot 2024-10-09 at 18 31 31

Screenshot 2024-10-09 at 18 35 34

Screenshot 2024-10-09 at 18 35 48

Testing Steps / QA Criteria

npm start
navigate to browser, resize the window to test the app's responsiveness

Copy link

github-actions bot commented Oct 9, 2024

Visit the preview URL for this PR (updated for commit 2025a68):

https://tcl-78-smart-shopping-list--pr60-el-style-refactor-wj3lz9li.web.app

(expires Wed, 16 Oct 2024 17:38:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

Copy link
Collaborator

@GrannyYetta GrannyYetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, Eva! The app certainly looks a great deal better and it works well for me in dark mode.

I do have one suggestion: the sign in button at the beginning is aligned to the left and it is twice in the landing page. I suggest we center it and present it only once rather than twice on the page.

Captura de pantalla 2024-10-09 a la(s) 18 59 03

Copy link
Collaborator

@vivitt vivitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 💥
The app looks really nice and I love the chosen color scheme.
You did a great work using the @apply directive to extract classes and also deleting the unused CSS.

I noticed that the navigation bar overlaps with the list when it has many items:

Screen Shot 2024-10-09 at 23 03 19

I think this might affect usability and just wanted to make sure you were aware, especially in dark mode where some links may disappear into the item's background color:

Screen Shot 2024-10-09 at 23 03 36

@eva-lng eva-lng merged commit 05d30d9 into main Oct 9, 2024
2 checks passed
@eva-lng eva-lng removed the request for review from Amaka202 October 9, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants