Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete and style about view #63

Merged
merged 5 commits into from
Oct 13, 2024
Merged

complete and style about view #63

merged 5 commits into from
Oct 13, 2024

Conversation

GrannyYetta
Copy link
Collaborator

Description

The application includes a page with information about the application, it's function and the developers who made it.

Related Issue

closes #57

Acceptance Criteria

  • Include a short paragraph that contextualized the application
    • Include the app's functions and instructions
    • Include its purpose
    • Include a link to the app's GitHub Repository
  • Include a reference to the TCL Program
    • Add a link to the TCL website
  • The page should include all four developers of the application.
    • Display their respective LinkedIn profiles
    • Display their respective GitHub profiles
  • Include a short thank you to the mentors
    • Display their respective LinkedIn profiles

Type of Changes

enhancement

Updates

Before

Captura de pantalla 2024-10-12 a la(s) 22 39 14

After

Captura de pantalla 2024-10-12 a la(s) 23 00 11

Testing Steps / QA Criteria

  1. npm start
  2. Navigate to the About view
  3. Click on the icons
  4. Scroll through the page

Copy link

github-actions bot commented Oct 12, 2024

Visit the preview URL for this PR (updated for commit afc87ee):

https://tcl-78-smart-shopping-list--pr63-rt-about-view-9bodhsb6.web.app

(expires Sun, 20 Oct 2024 10:07:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c781903507c1507075d7a974036959ddeec29c0a

Copy link
Collaborator

@eva-lng eva-lng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Explains in a concise way how the app works. I like that the collab lab and mentors are mentioned in here as well

Copy link
Collaborator

@vivitt vivitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ⚡️ nice explanation and an excellent way to include devs GH account and LinkedIn links. Also, thanks for mentioning us mentors and TCL project ❤️

@GrannyYetta GrannyYetta merged commit 9cf1d33 into main Oct 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

56. As a user, I want to access information the app and who made it
3 participants