generated from the-collab-lab/smart-shopping-list
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev branch into main #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… desktop and mobile/tablet
…bile devices, add icons to navbar to match the design
…ition for light to dark mode switch, remove unnecessary button from homepage.
… and apply custom colors to the project
…cons - Moved the Navbar component into its own dedicated file for better separation of concerns and maintainability - Added basic tooltips to non-navbar icons (dark mode toggle, sign-in/sign-out buttons)
…and-modifications Relocate Add Item Functionality to Modal on List Page
…ttom-right of the page where it was before
Mm feature/navbar layout
Implement design for list page
…n with Figma design
Fix spacing issue
…item-singlelist-styling
…-singlelist-styling Mm feature/update listitem singlelist styling
Feat: Delete lists
…te inactive share button style to match delete button.
Consistent dark and light theme throughout app
Edit individual list items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we have integrated Tailwind CSS and ShadCN into the project for styling, aligning the implementation with the Figma design. Key changes include:
Note:
While we've made significant progress in implementing the styling, the overall design still requires additional refinements and will need a thorough redesign to meet our final vision.
Related Issue
Closes #31 , #32, #33, #35
Acceptance Criteria
The acceptance criteria for this PR are specified in Issue #14.
Type of Changes
Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g.,
bug fix
orenhancement
are common ones.enhancement
,bug fix
,refactor
,feature
,style
Updates
Before
After
Testing Steps / QA Criteria
After this PR is merged, ensure you're on the main branch.
git checkout main
and pull the latest changes withgit pull
.npm install
to ensure all dependencies are up to date.After this, you can check the app's functionality and basic styling.
Note: Some styling adjustments are still pending, and the overall design will require additional refinements in future updates following today's merge.