-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Delete lists #53
Conversation
Visit the preview URL for this PR (updated for commit ed975e4): https://tcl-79-smart-shopping-list--pr53-qg-feat-delete-list-n4wzcj53.web.app (expires Sat, 19 Oct 2024 18:39:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a brilliant feature! Well done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @Wyna-7 really that was a tough one! 🙌 just one thing i think adding an alert dialog to check with the user before deleting a list would be good.
Well done @Wyna-7!🤾🏾♀️ Yeah I agree with Huda, to add a prompt if the user is really sure they want to delete that list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👏 just one thing make sure the delete dialog color scheme match the list page one before merging.
Description
Users can now delete lists from the home page. They are only allowed to delete lists they have created themselves, the button is disabled for lists that have been shared with the logged user.
Deleting a list removes the corresponding document in the user's collecton, and the reference to it in the sharedLists field array.
Related Issue
Closes #36
Acceptance Criteria
Type of Changes
feat
Updates
Before
Pretty much the same.
After
Disabled button is now grey.
No list selected
Testing Steps / QA Criteria
git pull
and thengit checkout qg-feat-delete-list
npm start
to open GrocerEaseLists
page should show the no list selected text.